Skip to content

Treat EventLevel.Verbose as debug log level #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevejgordon merged 2 commits into from
Jul 25, 2025
Merged

Treat EventLevel.Verbose as debug log level #288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d868940
Treat EventLevel.Verbose as debug log level
stevejgordon Jul 23, 2025
d405385
Fix test logger message enumeration
stevejgordon Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test logger message enumeration
  • Loading branch information
@stevejgordon
stevejgordon committed Jul 25, 2025
commit d405385670f07350f30de322926b45b1aa9b7d7c
8 changes: 5 additions & 3 deletions tests/Elastic.OpenTelemetry.Tests/Diagnostics/LoggingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public void LoggingPreamble_IsSkipped_WhenReusingSharedComponents()
.WithElasticDefaults(options)
.Build();

Assert.Single(logger.Messages, m => EdotPreamble().IsMatch(m));
var messages = logger.Messages.ToArray();
Assert.Single(messages, m => EdotPreamble().IsMatch(m));

using var meterProvider = Sdk.CreateMeterProviderBuilder()
.WithElasticDefaults(options)
Expand All @@ -65,7 +66,8 @@ public void LoggingPreamble_IsSkipped_WhenReusingSharedComponents()

// On this builder, because we are reusing the same ElasticOpenTelemetryOptions, shared components will be available,
// and as such, the pre-amble should not be output a second time.
Assert.Single(logger.Messages, m => EdotPreamble().IsMatch(m));
Assert.Contains(logger.Messages, m => UsingSharedComponents().IsMatch(m));
messages = logger.Messages.ToArray();
Assert.Single(messages, m => EdotPreamble().IsMatch(m));
Assert.Contains(messages, m => UsingSharedComponents().IsMatch(m));
}
}