Skip to content

Fix validation of multi-fields of external fields #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 10, 2023
Merged

Fix validation of multi-fields of external fields #1335

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f076aba
Look for field definitions also in multi-fields
jsoriano Jun 29, 2023
9e59989
Add test that reproduces the issue
jsoriano Jun 29, 2023
6093d8e
Inject external fields when creating the validator
jsoriano Jun 29, 2023
fa6a4d6
Remove unneeded reference to field dependency manager
jsoriano Jun 29, 2023
403c4a0
Make importField private
jsoriano Jun 29, 2023
62597d2
Keep options provided by caller
jsoriano Jun 29, 2023
72563f3
Update test files
jsoriano Jun 29, 2023
3fbf044
Remove irrelevant data streams
jsoriano Jun 29, 2023
d1eaefb
Remove unneeded error handling
jsoriano Jun 30, 2023
6d644a7
Keep printing empty groups from ECS, for backwards compatibility reasons
jsoriano Jun 30, 2023
a0d794a
Add godocs to KeepExternal
jsoriano Jun 30, 2023
970e166
Regenerate README
jsoriano Jul 3, 2023
3a378da
Merge remote-tracking branch 'origin/main' into ecs-multi-fields
jsoriano Jul 3, 2023
d817ab6
Keep empty fields for fields validation, but not for documentation
jsoriano Jul 3, 2023
d80b5fb
Review unit tests
jsoriano Jul 3, 2023
ff8b347
Fix inject fields recursion
jsoriano Jul 3, 2023
1131866
Add test case
jsoriano Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add godocs to KeepExternal
  • Loading branch information
@jsoriano
jsoriano committed Jun 30, 2023
commit a0d794a3ca60f8b70ee121b0f6265764ccd9b912
3 changes: 3 additions & 0 deletions internal/fields/dependency_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ func asGitReference(reference string) (string, error) {

// InjectFieldsOptions allow to configure fields injection.
type InjectFieldsOptions struct {
// KeepExternal can be set to true to avoid deleting the `external` parameter
// of a field when resolving it. This helps keeping behaviours that depended
// in previous versions on lazy resolution of external fields.
KeepExternal bool

root string
Expand Down