Skip to content

[Refactor] Refactor common code between all benchmark commands #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Refactor] Refactor common code between all benchmark commands #1611

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
505b5e7
[Refactor] Refactor common code between all benchmark commands
ruflin Dec 21, 2023
3de300c
remove obsolete methods
ruflin Dec 21, 2023
7bea775
add note about more common fields that colud use refactoring
ruflin Dec 21, 2023
e6c57b6
Merge branch 'main' into benchrunner-refactor
ruflin Jan 15, 2024
e5d444a
cleanup imporots
ruflin Jan 15, 2024
25d73b2
Merge branch 'main' into benchrunner-refactor
ruflin Jan 22, 2024
dab5303
remove todo
ruflin Jan 23, 2024
7548ee2
Merge branch 'main' into benchrunner-refactor
ruflin Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove todo
  • Loading branch information
@ruflin
ruflin committed Jan 23, 2024
commit dab5303877c8cf229df1c29fd2686131202746c5
2 changes: 0 additions & 2 deletions internal/benchrunner/runners/system/scenario.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,11 @@ type scenario struct {
Corpora corpora `config:"corpora" json:"corpora"`
}

// TODO: Why is this slightly different from the common fields?
type dataStream struct {
Name string `config:"name" json:"name"`
Vars map[string]interface{} `config:"vars" json:"vars"`
}

// TODO: Why is this slightly different from the common fields?
type corpora struct {
Generator *common.Generator `config:"generator" json:"generator"`
InputService *inputService `config:"input_service" json:"input_service"`
Expand Down