Skip to content

Check failure store when available during system tests #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 24, 2024
Merged

Check failure store when available during system tests #1973

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
dfbb951
Add helper to enable or disable failure store in index template
jsoriano Jul 12, 2024
67b9426
Don't update the data stream if already in the expected state
jsoriano Jul 12, 2024
0199402
Fix typo
jsoriano Jul 12, 2024
63b883c
Enable and check failure store on system tests
jsoriano Jul 15, 2024
22fa9b7
Interrupt loop waiting docs if there are docs in the failure store
jsoriano Jul 15, 2024
574a8a2
Include error message in results
jsoriano Jul 15, 2024
12548f2
Ignore errors in the failure store caused by document conflicts
jsoriano Jul 16, 2024
e14ac74
Filter out errors about conflicting documents
jsoriano Jul 16, 2024
08332d4
Add test case
jsoriano Jul 18, 2024
842cc74
Ensure feature is enabled
jsoriano Jul 18, 2024
42f9b52
Add missing fields to test package
jsoriano Jul 18, 2024
9fe6090
Remove use of feature flag
jsoriano Jul 18, 2024
f9bcf0e
Enable failure store also in 8.14
jsoriano Jul 18, 2024
0f63308
Explicitly check if the failure store is available
jsoriano Jul 18, 2024
a8c71d5
Rename method to check if failure stoe is available
jsoriano Jul 18, 2024
69ffa36
Linting
jsoriano Jul 18, 2024
11cddae
Support failure store since 8.15.0
jsoriano Jul 18, 2024
b911556
Show additional info in errors
jsoriano Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Show additional info in errors
  • Loading branch information
@jsoriano
jsoriano committed Jul 23, 2024
commit b91155614c243a3c91e5252d17f2d1727bab2c44
17 changes: 14 additions & 3 deletions internal/testrunner/runners/system/tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,8 +843,12 @@ type scenarioTest struct {

type failureStoreDocument struct {
Error struct {
Type string `json:"type"`
Message string `json:"message"`
Type string `json:"type"`
Message string `json:"message"`
StackTrace string `json:"stack_trace"`
PipelineTrace []string `json:"pipeline_trace"`
Pipeline string `json:"pipeline"`
ProcessorType string `json:"processor_type"`
} `json:"error"`
}

Expand Down Expand Up @@ -1966,7 +1970,14 @@ func writeSampleEvent(path string, doc common.MapStr, specVersion semver.Version
func validateFailureStore(failureStore []failureStoreDocument) error {
var multiErr multierror.Error
for _, doc := range failureStore {
multiErr = append(multiErr, errors.New(doc.Error.Message))
// TODO: Move this to the trace log level when available.
logger.Debug("Error found in failure store: ", doc.Error.StackTrace)
multiErr = append(multiErr,
fmt.Errorf("%s: %s (processor: %s, pipelines: %s)",
doc.Error.Type,
doc.Error.Message,
doc.Error.ProcessorType,
strings.Join(doc.Error.PipelineTrace, ",")))
}

if len(multiErr) > 0 {
Expand Down