Skip to content

Add detection of source.mode synthetics for 8.17.2 onwards #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Add detection of source.mode synthetics for 8.17.2 onwards #2400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add detection of source.mode synthetics for 8.17.2 onwards
  • Loading branch information
@mrodm
mrodm committed Feb 12, 2025
commit e35f7e390826b03f32462d32357a4f8ad33c9aa0
10 changes: 8 additions & 2 deletions internal/testrunner/runners/system/tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,12 @@ func isSyntheticSourceModeEnabled(ctx context.Context, api *elasticsearch.API, d
} `json:"mappings"`
Settings struct {
Index struct {
Mode string `json:"mode"`
Mode string `json:"mode"`
Mapping struct {
Source struct {
Mode string `json:"mode"`
} `json:"source"`
} `json:"mapping"`
} `json:"index"`
} `json:"settings"`
} `json:"template"`
Expand All @@ -691,7 +696,8 @@ func isSyntheticSourceModeEnabled(ctx context.Context, api *elasticsearch.API, d
return false, fmt.Errorf("could not decode index template simulation response: %w", err)
}

if results.Template.Mappings.Source.Mode == "synthetic" {
// in 8.17.2 source mode definition is now under settings object
if results.Template.Mappings.Source.Mode == "synthetic" || results.Template.Settings.Index.Mapping.Source.Mode == "synthetic" {
return true, nil
}

Expand Down