Skip to content

Enable validation based on mappings by default #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Enable validation based on mappings by default #2410

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd24f7f
Set by default validation based on mappings
mrodm Feb 14, 2025
2ff0a93
Remove technical preview
mrodm Feb 14, 2025
1d00e53
Update docs env. var
mrodm Feb 14, 2025
c7a5ee7
Update system testing docs
mrodm Feb 14, 2025
8e7fc3b
Re-generate README
mrodm Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove technical preview
  • Loading branch information
@mrodm
mrodm committed Feb 14, 2025
commit 2ff0a93af8dd02699b17628cc7b087646dde4d03
2 changes: 1 addition & 1 deletion internal/testrunner/runners/system/tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,7 +1646,7 @@ func (r *tester) validateTestScenario(ctx context.Context, result *testrunner.Re
}

if r.fieldValidationMethod == mappingsMethod {
logger.Warn("Validation based on mappings enabled (technical preview)")
logger.Debug("Performing validation based on mappings")
Copy link
Contributor Author

@mrodm mrodm Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the advantage of removing the technical preview status, since it is going to be enabled by default.

I thought that maybe this message could help to identify if the validation based on mappings has been executed or not. WDYT ?

exceptionFields := listExceptionFields(scenario.docs, fieldsValidator)

mappingsValidator, err := fields.CreateValidatorForMappings(r.esClient,
Expand Down