Skip to content

Conversation

@maximilianpohle
Copy link
Contributor

Hi everybody,
due to the reduced Docker rate limits, it may happen that the stack can no longer be downloaded because of the is_ready Docker image.

Therefore, I have created an additional environment variable that allows overriding the image.

Best regards
Max

@jsoriano
Copy link
Member

/test

jsoriano
jsoriano previously approved these changes Jun 13, 2025
@jsoriano jsoriano dismissed their stale review June 13, 2025 08:34

Missing code conventions

@maximilianpohle
Copy link
Contributor Author

@jsoriano @mrodm Thanks for checking! Can you please review again.

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just added minor comments.
It would be needed to check if the environment variable can be used to define the docker-compose scenario in the sql_input test package.

@mrodm
Copy link
Contributor

mrodm commented Jun 25, 2025

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 25, 2025

@mrodm
Copy link
Contributor

mrodm commented Jun 30, 2025

/test

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maximilianpohle
Copy link
Contributor Author

@mrodm @jsoriano Thanks for approving! Can we merge?

@mrodm
Copy link
Contributor

mrodm commented Jul 4, 2025

@mrodm @jsoriano Thanks for approving! Can we merge?

Sure, I'll merge this PR.
Thanks for your contribution @maximilianpohle !

@mrodm mrodm merged commit ce0337e into elastic:main Jul 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants