Skip to content

Chore(deps): bump github.com/elastic/package-spec/v3 from 3.3.5 to 3.4.0 #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Chore(deps): bump github.com/elastic/package-spec/v3 from 3.3.5 to 3.4.0 #2616

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15373d7
Chore(deps): bump github.com/elastic/package-spec/v3 from 3.3.5 to 3.4.0
dependabot[bot] May 27, 2025
1309b22
Remove test code for non-GA content packages
jsoriano May 27, 2025
d70f5ef
Merge branch 'main' into dependabot/go_modules/github.com/elastic/pac…
mergify[bot] May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test code for non-GA content packages
  • Loading branch information
@jsoriano
jsoriano committed May 27, 2025
commit 1309b22623943c2350d9b5bf187d680f310c5257
10 changes: 0 additions & 10 deletions internal/packages/archetype/package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"path/filepath"
"testing"

"github.com/Masterminds/semver/v3"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

Expand Down Expand Up @@ -63,15 +62,6 @@ func createPackageDescriptorForTest(packageType, kibanaVersion string) PackageDe
if err != nil {
panic(err)
}
if packageType == "content" {
minSpecVersion := semver.MustParse("3.4.0")
if !specVersion.LessThan(minSpecVersion) {
panic("this code can be removed")
}
version = "0.1.0"
specVersion = *minSpecVersion
excludeChecks = append(excludeChecks, "PSR00002")
}
Copy link
Member

@jsoriano jsoriano May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this code is not needed anymore because content packages are already GA cc @mrodm.

return PackageDescriptor{
Manifest: packages.PackageManifest{
SpecVersion: specVersion.String(),
Expand Down