Skip to content

Add docs about package types #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

Add docs about package types #2691

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b76014
Add docs about package types
jsoriano Jun 26, 2025
2456509
Add reference in document to create new package
jsoriano Jun 26, 2025
c22b160
We -> you
jsoriano Jun 26, 2025
f7a4996
Fix plural
jsoriano Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix plural
  • Loading branch information
@jsoriano
jsoriano committed Jun 26, 2025
commit f7a4996e5449c5d827d90bce167861d0178d0464
2 changes: 1 addition & 1 deletion docs/howto/package_types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ the type. If you are not sure, you can follow this section to help deciding:
For legacy reasons, integration packages can be used for most use cases. For
example a package can include dashboards without including any data stream, as
if it were a content package. Or an integration package can define a single data
Copy link
Contributor

@mrodm mrodm Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if it were a content package. Or an integration package can define a single data
if it was a content package. Or an integration package can define a single data

Copy link
Member Author

@jsoriano jsoriano Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think were is correct here 🤔

Copy link
Contributor

@mrodm mrodm Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm now I have doubts 😅
Probably, you're right and it should be as if it were... as an hypothetical situation.

Copy link
Member

@kpollich kpollich Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native English speaker here 👋 - both sound fine imo. Terrible language 😜

Copy link
Member Author

@jsoriano jsoriano Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

stream, as if it were an input packages.
stream, as if it were an input package.

Even when this is true, these cases push integration packages (and the code
supporting them) beyond what they were designed for. By having different types
Expand Down