Skip to content

Rely on os.Root for checking paths #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

Rely on os.Root for checking paths #2752

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4756d86
Rely on os.Root for checking paths
jsoriano Jul 21, 2025
0adf6fa
Fix test in windows
jsoriano Jul 21, 2025
728851d
Apply suggestions from review
jsoriano Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test in windows
  • Loading branch information
@jsoriano
jsoriano committed Jul 21, 2025
commit 0adf6fa7be3b9f71837fa44524103a08e1a101ce
8 changes: 7 additions & 1 deletion internal/files/linkedfiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"io"
"os"
"path/filepath"
"runtime"
"strings"
"testing"

Expand Down Expand Up @@ -782,6 +783,11 @@ func TestLinksFS_ErrorConditions(t *testing.T) {
lfs, err := NewLinksFS(root, workDir)
require.NoError(t, err)

notFoundErrorMsg := "no such file or directory"
if runtime.GOOS == "windows" {
notFoundErrorMsg = "The system cannot find the file specified"
}

tests := []struct {
name string
fileName string
Expand All @@ -790,7 +796,7 @@ func TestLinksFS_ErrorConditions(t *testing.T) {
{
name: "broken link to non-existent file",
fileName: "broken.txt.link",
errorMsg: "no such file or directory",
errorMsg: notFoundErrorMsg,
},
{
name: "invalid link file format",
Expand Down