Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

More easily digested introduction #155

Closed
wants to merge 2 commits into from
Closed

More easily digested introduction #155

wants to merge 2 commits into from

Conversation

bjorn-ali-goransson
Copy link
Contributor

An attempt to a more easily digested introduction with actual attachment data to shorten the runway.

@dadoonet
Copy link
Contributor

dadoonet commented Sep 3, 2015

Could you sign the CLA please?

@bjorn-ali-goransson
Copy link
Contributor Author

Done!

2015-09-03 23:27 GMT+02:00 David Pilato [email protected]:

Could you sign the CLA please?

—
Reply to this email directly or view it on GitHub
#155 (comment)
.

dadoonet
dadoonet reviewed Sep 4, 2015
View reviewed changes
README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this section after Installation part? So it's looking more like what we have in our guide?

For example: https://www.elastic.co/guide/en/elasticsearch/plugins/2.0/analysis-icu.html

@dadoonet
Copy link
Contributor

dadoonet commented Sep 4, 2015

I really like your change! I left some comments.
Could you address them, then squash in a single commit?

[doc] Add "Hello world" introduction section

An attempt to a more easily digested introduction with actual attachment data to shorten the runway.

@dadoonet dadoonet added this to the 3.1.0 milestone Sep 4, 2015
@dadoonet dadoonet added the 4.0.0 label Sep 4, 2015
@dadoonet dadoonet self-assigned this Sep 4, 2015
@bjorn-ali-goransson
Copy link
Contributor Author

@dadoonet how would I squash it into one single commit?

@dadoonet
Copy link
Contributor

dadoonet commented Sep 8, 2015

git rebase -i master then edit the commits file and mark lines but the first as "squash".
Save, then edit the commit message. Then save.

Done.

Then force push your changes in your repo.

If something goes wrong while rebasing, run git rebase --abort.

Improved introduction, added hello world
286e42e 
New paragraph

Some abbreviation to 1st paragraph

More concise phrasing

Rename heading

Remove repeated "Now," from Hello World

Person is also a document

Rephrasing of last paragraph in Hello, World

Move installation to being above Hello, world

Accidentally left out moving code backticks. Fixed
@bjorn-ali-goransson
Copy link
Contributor Author

I think I did it?

@dadoonet
Copy link
Contributor

dadoonet commented Sep 8, 2015

Looks great. I'll merge it later today.

Thanks !

@bjorn-ali-goransson bjorn-ali-goransson mentioned this pull request Oct 12, 2015
Open
@dadoonet dadoonet added the 3.0.2 label Oct 23, 2015
@dadoonet dadoonet modified the milestones: 3.0.2, 3.1.0 Oct 23, 2015
@dadoonet dadoonet closed this in 88ca607 Oct 23, 2015
dadoonet pushed a commit that referenced this pull request Oct 23, 2015
@dadoonet
Improved introduction, added hello world
4dc9aec 
New paragraph

Some abbreviation to 1st paragraph

More concise phrasing

Rename heading

Remove repeated "Now," from Hello World

Person is also a document

Rephrasing of last paragraph in Hello, World

Move installation to being above Hello, world

Accidentally left out moving code backticks. Fixed

Closes #155
(cherry picked from commit 88ca607)
@dadoonet
Copy link
Contributor

So I picked the first commit and ignored the second one in your branch.

Thanks!

@dadoonet dadoonet changed the title Updates to README.md More easily digested introduction Oct 23, 2015
@dadoonet dadoonet removed the 3.0.3 label Oct 28, 2015
@dadoonet dadoonet removed the 3.0.4 label Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dadoonet dadoonet

Labels
3.0.2 doc
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn-ali-goransson @dadoonet