fix #3019, converter should not nullify know keys in the base dictionary #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Jan 16, 2018
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM, much cleaner to read. Just one small question
| d[UpdatableIndexSettings.UnassignedNodeLeftDelayedTimeout] = ds.UnassignedNodeLeftDelayedTimeout; | ||
| void Set(string knownKey, object newValue) | ||
| { | ||
| if (newValue != null) d[knownKey] = newValue; |
Contributor
There was a problem hiding this comment.
Might you want to set a null value too?
Member
Author
There was a problem hiding this comment.
That would always override what is set in the backing dictionary which is what triggered #3019
Mpdreamz
force-pushed
the
fix/known-index-settings
branch
from
79ba342 to
9fc4f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.