Backport mapper-attachments plugin to 2.x #14902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says we support EPUB, but the parser is not enabled. This parser does not require any external dependencies, so I think its ok? Separately, test-framework drags in an ancient commons-codec (via httpclient), which gradle "upgrades", but IDEs can't handle this case and just hit jar hell. So just wire that to 1.9, this allows running tests in the IDE for this plugin.
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Nov 20, 2015
backport mapper-attachments plugin to 2.x
dadoonet
added a commit
to elastic/elasticsearch-mapper-attachments
that referenced
this pull request
Nov 23, 2015
The code moved to elasticsearch repository. See elastic/elasticsearch#14902 So we can close the `es-2.x` branch.
clintongormley
changed the title
clintongormley
added
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got this thing in pretty good shape in master, but a big part of making it better was cleaning up the dependencies management: we use a parser whitelist and that does not work well with maven.
The solution here based on the fact that in master, gradle translates our whitelist into 24KB of horrible XML automatically for us, we can just paste that directly into maven if we need to upgrade tika. So, the POM.xml for this plugin has this warning:
I think its a good solution for 2.x