Skip to content

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Jan 10, 2025

Relates #3935

Do tests in the packages failed when using the validation based on mappings.

@mrodm mrodm self-assigned this Jan 10, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 10, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Comment on lines 4 to 7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously they were mapped as keyword, with this change they would be date.

Comment on lines 4 to 6
Copy link
Collaborator Author

@mrodm mrodm Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously they were mapped as keyword, with this change they would be date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition was generating a dynamic template to transform objects to flattened, and it was not recognizing the fields under assessments like assessments.application_firewall_mac.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition was generating a dynamic template to transform objects to flattened, and it was not recognizing the fields under vmstats like vmstats.allocstall_device.

@mrodm mrodm force-pushed the test-packages-mappings branch from 559b439 to dd4535c Compare February 6, 2025 12:45
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
22.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@mrodm mrodm closed this Mar 4, 2025
@mrodm mrodm deleted the test-packages-mappings branch March 4, 2025 11:19
@andrewkroh andrewkroh added Integration:ti_custom Custom Threat Intelligence Integration:tychon TYCHON Agentless (Partner supported) Integration:wiz Wiz Integration:github GitHub Integration:teleport Teleport Integration:ti_anomali Anomali labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:github GitHub Integration:teleport Teleport Integration:ti_anomali Anomali Integration:ti_custom Custom Threat Intelligence Integration:tychon TYCHON Agentless (Partner supported) Integration:wiz Wiz

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants