-
Notifications
You must be signed in to change notification settings - Fork 511
[CI] Add custom prefix to service RunID tests used in system tests #14582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
cloudwatch_logs |
500000 | 333333.33 | -166666.67 (-33.33%) | 💔 |
elb_logs |
4807.69 | 3861 | -946.69 (-19.69%) | 💔 |
To see the full report comment with /test benchmark fullreport
0013c62 to
65c2bac
Compare
This reverts commit 65c2bac.
go.mod
Outdated
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/elastic/elastic-package => github.com/mrodm/elastic-package v0.53.1-0.20250717153626-3c5c9c47f9d8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait for a new version of elastic-package, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to wait for a new version.
In this commit ffb5f8d I'm removing that replacement. It was there just to test that elastic-package run the system tests as expected.
|
|
Merging PR since after retrying the builds failed, just This is a known issue #14523 |





Proposed commit message
Include the required environment variables to customize the TestRunID used in system tests run by elastic-package. This TestRunID is used among other things to add a suffix in the resources created by terraform.
Example of bucket created adding the prefix:
elastic-package-canva-bucket-eabc63175eabcprefix added63175previous TestRunID valueAuthor's Checklist
canvapackage that creates resources in AWS via terraform.How to test this PR locally
Related issues