Skip to content

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Jul 17, 2025

Proposed commit message

Include the required environment variables to customize the TestRunID used in system tests run by elastic-package. This TestRunID is used among other things to add a suffix in the resources created by terraform.

Example of bucket created adding the prefix:

  • elastic-package-canva-bucket-eabc63175
    • eabc prefix added
    • 63175 previous TestRunID value

Author's Checklist

  • Test with canva package that creates resources in AWS via terraform.

How to test this PR locally

elastic-package stack up -v -d
cd packages/<package>/

export ELASTIC_PACKAGE_PREFIX_SERVICE_TEST_RUN_ID=1a2b
elastic-package test system -v

elastic-package stack down -v

Related issues

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 17, 2025

🚀 Benchmarks report

Package aws 👍(15) 💚(5) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cloudwatch_logs 500000 333333.33 -166666.67 (-33.33%) 💔
elb_logs 4807.69 3861 -946.69 (-19.69%) 💔

To see the full report comment with /test benchmark fullreport

@mrodm mrodm changed the title Ci add prefix service runid tests [CI] Add custom prefix to service RunID tests used in system tests Jul 18, 2025
@mrodm mrodm force-pushed the ci_add_prefix_service_runid_tests branch from 0013c62 to 65c2bac Compare July 18, 2025 10:16
@mrodm mrodm self-assigned this Jul 18, 2025
This reverts commit 65c2bac.
@mrodm mrodm marked this pull request as ready for review July 18, 2025 14:06
@mrodm mrodm requested a review from a team as a code owner July 18, 2025 14:06
go.mod Outdated
sigs.k8s.io/yaml v1.4.0 // indirect
)

replace github.com/elastic/elastic-package => github.com/mrodm/elastic-package v0.53.1-0.20250717153626-3c5c9c47f9d8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait for a new version of elastic-package, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for a new version.

In this commit ffb5f8d I'm removing that replacement. It was there just to test that elastic-package run the system tests as expected.

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mrodm
Copy link
Collaborator Author

mrodm commented Jul 18, 2025

Merging PR since after retrying the builds failed, just apache and nginx packages have failed https://buildkite.com/elastic/integrations/builds/28762

This is a known issue #14523

@mrodm mrodm merged commit 7746f33 into elastic:main Jul 18, 2025
8 of 9 checks passed
@mrodm mrodm deleted the ci_add_prefix_service_runid_tests branch July 18, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants