Skip to content

Conversation

@alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Aug 13, 2025

This PR:

@alaudazzi alaudazzi requested a review from a team August 13, 2025 06:23
@alaudazzi alaudazzi self-assigned this Aug 13, 2025
@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Aug 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

🔍 Preview links for changed docs

@alaudazzi alaudazzi requested a review from a team August 13, 2025 13:46
@alaudazzi alaudazzi marked this pull request as ready for review August 13, 2025 13:46
@alaudazzi alaudazzi requested a review from a team as a code owner August 13, 2025 13:46
@alaudazzi
Copy link
Contributor Author

@kgeller @mjwolf @haetamoudi
A few points to consider:

@kgeller
Copy link
Contributor

kgeller commented Aug 13, 2025

Great call out! I'll add an issue today for that, and make sure there aren't any other pages in that folder that we're missing

I forgot we already have updated that file with our first elastic-package change here. All the other files in the folder aren't relevant. Skipping the new issue 👍

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

* [What do I need to use this integration?](#idg-requirements)
* [How do I deploy this integration?](#idg-docs-setup)
* [Troubleshooting](#idg-docs-troubleshooting)
* [Performance and scaling](#idg-docs-performance-scaling)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The performance and scaling depends on the users underlying infrastructure. Currently, I am noticing the ingest architecture is shared for one of the integrations. Is this an optional section in the document?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all sections should be included where applicable and if there is relevant content.

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alaudazzi alaudazzi merged commit 21a5755 into main Aug 20, 2025
7 checks passed
@alaudazzi alaudazzi deleted the fix-844 branch August 20, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants