[cloud] Get user email for chat from metadata saml name #124260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyPoluektov
added
Team:Cloud
release_note:skip
clintandrewhall
requested changes
Feb 1, 2022
| let { email: userEmail, username: userId } = user || {}; | ||
| const { metadata, username } = user || {}; | ||
| let userId = username; | ||
| let [userEmail] = (metadata as MetaWithSaml)?.saml_name || []; |
Contributor
There was a problem hiding this comment.
This is incorrect, based on what I'm seeing in Cloud... we need saml_email. The token is coming back, but the AWS frame is rejecting it. I'll update and redeploy to test.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
I went ahead and opened #124301 and deployed it to Cloud. I'm going to close this PR for a clean review from core. |
clintandrewhall
added
the
Feature:Chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #123772
This PR is fixing the issue with getting user email in the cloud environment.
AuthenticatedUserobject has fieldemailwhich is set tonullvalue even in the cloud env. Based on the internal slack discussion we find out that we can safely useAuthenticatedUser.metadata.saml_nameproperty to obtain a user email.Checklist
For maintainers