-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Drift] Add to security/get_started and observability/overview
#159797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
security/get_started and observability/overview
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
afharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core changes LGTM
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explore chages LGTM!
maryam-saeidi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@maryam-saeidi, yes, unfortunately, this is an issue with the Drift chat integration which needs some love. This is only a Dev warning and functionality wise it works as expected. I'll create an issue to clean this up |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dosant, I approve the PR since, as you mentioned, it is only a dev warning.
The challenge with these warnings is that they make it harder to notice valid issues in the developer console. Will you please make sure that the ticket will be picked up sooner? 🙂
|
@Dosant what is the easiest way to test that this is working for the Enterprise Search page? I can't create an 8.9 deployment trial. |
@sixstringcode , This was added to enterprise search here: #124176 |
|
Thanks Anton, following the PRs cleared it up. |



Summary
Partially address #158835
Fix #159800
We're adding Drift to a couple of "high value" pages identified by the CSE team #158835. For now we don't add Drift globally because we have a bunch of concerns we need to resolve first #159691
To see how the chat bubble looks, you can use these URLs with my dummy test drift account: