Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Jun 9, 2023

Closes #1714

We had to downgrade to 3.11.0 in #1712 to work around an asyncio/aiohttp bug. Now that this bug was fixed in python/cpython#104485 and released in Python 3.11.4, we can bump the Python 3.11 version.

@danielmitterdorfer @b-deam Is there an easy way to confirm this fixes the issue?

@pquentin pquentin added bug Something's wrong :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Jun 9, 2023
@pquentin pquentin self-assigned this Jun 9, 2023
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-deam
Copy link
Member

b-deam commented Jun 13, 2023

Closes #1714

We had to downgrade to 3.11.0 in #1712 to work around an asyncio/aiohttp bug. Now that this bug was fixed in python/cpython#104485 and released in Python 3.11.4, we can bump the Python 3.11 version.

@danielmitterdorfer @b-deam Is there an easy way to confirm this fixes the issue?

I was only able to reproduce on a very long running benchmark (took 10h+ to repro), so I've started one using this branch.

Copy link
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't reproduce, so LGTM!

@pquentin
Copy link
Member Author

Awesome, thanks a lot for taking the time and energy!

@pquentin pquentin merged commit 675f1bd into elastic:master Jun 14, 2023
@pquentin pquentin deleted the 3.11.4 branch June 14, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something's wrong :internal Changes for internal, undocumented features: e.g. experimental, release scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute '_abort' on aiohttp connection close

3 participants