Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix: remove array buffer allocator patch (electron-4.x) #110

Open
wants to merge 12 commits into
base: electron-node-v10.11.0-V8-6.9
Choose a base branch
from
Open

fix: remove array buffer allocator patch (electron-4.x) #110

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
982406e
Revert "fix: allocate memory of Buffer with V8's allocator"
deepak1556 Jul 10, 2019
c2ac649
crypto: fix malloc mixing in X509ToObject
davidben Jan 25, 2019
4f63360
crypto: don't crash X509ToObject on error
davidben Jan 29, 2019
dea1404
src: allocate Buffer memory using ArrayBuffer allocator
addaleax Feb 18, 2019
5538126
src: make IsolateData store ArrayBufferAllocator
addaleax Feb 18, 2019
6418b51
worker: copy transferList ArrayBuffers on unknown allocator
addaleax Feb 19, 2019
8867a26
src: add debugging array allocator
addaleax Feb 18, 2019
b2ed6c3
src: add allocation utils to env
addaleax Feb 18, 2019
7b35642
buffer: throw exception when creating from non-Node.js Context
addaleax Oct 28, 2018
e13e8fe
src: remove outdated `Neuter()` call in `node_buffer.cc`
addaleax Jan 13, 2019
9027c0f
tls: fix malloc mismatch in SSL_set_tlsext_status_ocsp_resp call
davidben Jan 25, 2019
1ca642c
http2: fix tracking received data for maxSessionMemory
addaleax May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: remove outdated Neuter() call in node_buffer.cc 
This call was introduced in 827ee49 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a,
rendering the original call unnecessary.

Refs: nodejs/node#3624
Refs: nodejs/node#5204

PR-URL: nodejs/node#25479
Reviewed-By: Anatoli Papirovski <[email protected]>
  • Loading branch information
@addaleax @deepak1556
addaleax authored and deepak1556 committed Jul 10, 2019
commit e13e8fe0bff67de3c600096ae0c1818b22a082a8
5 changes: 0 additions & 5 deletions src/node_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,11 +355,6 @@ MaybeLocal<Object> New(Environment* env,
}

Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), data, length);
// `Neuter()`ing is required here to prevent materialization of the backing
// store in v8. `nullptr` buffers are not writable, so this is semantically
// correct.
if (data == nullptr)
ab->Neuter();
MaybeLocal<Uint8Array> ui = Buffer::New(env, ab, 0, length);

if (ui.IsEmpty()) {
Expand Down