Skip to content

feat!: bump engines requirement to Node 22#1821

Merged
erickzhao merged 34 commits intomainfrom
feat/node-22
Sep 10, 2025
Merged

feat!: bump engines requirement to Node 22#1821
erickzhao merged 34 commits intomainfrom
feat/node-22

Conversation

@erickzhao
Copy link
Copy Markdown
Member

BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.

@erickzhao erickzhao marked this pull request as ready for review September 3, 2025 20:10
@erickzhao erickzhao requested a review from a team as a code owner September 3, 2025 20:10
Comment thread src/common.ts Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread .eslintrc.cjs
Comment thread src/platform.ts Outdated
@erickzhao erickzhao requested a review from erikian September 5, 2025 20:43
Comment thread src/types.ts Outdated
Comment thread src/dynamicImport.js
Comment thread src/win32.ts Outdated
erickzhao and others added 4 commits September 8, 2025 10:35
Co-authored-by: Erik Moura <erikian@electronjs.org>
Co-authored-by: Erik Moura <erikian@electronjs.org>
@socket-security
Copy link
Copy Markdown

socket-security bot commented Sep 8, 2025

Comment thread src/mac.ts

export function createSignOpts(
properties: ComboOptions['osxSign'],
properties: Exclude<ComboOptions['osxSign'], undefined>,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After @erikian's latest round of reviews, a few things have changed in the implementation purely due to tightening up the types:

  • createSignOpts for macOS and Windows no longer takes in undefined.
  • Missing continueOnError option added to Windows.
  • We pass in identity: undefined instead of identity: null as a default for macOS since that's what the types expect for @electron/osx-sign.
  • More explicit control flow in createSignOpts.

These are all improvements that can be separated out of this PR as well if we think this is too scope-creepy.

@erickzhao erickzhao merged commit 8d64aa1 into main Sep 10, 2025
6 checks passed
@erickzhao erickzhao deleted the feat/node-22 branch September 10, 2025 16:40
@continuous-auth
Copy link
Copy Markdown

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants