feat!: bump engines requirement to Node 22#1821
Merged
Conversation
BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.
d38a870 to
861fb4b
Compare
MarshallOfSound
approved these changes
Sep 5, 2025
erikian
reviewed
Sep 5, 2025
Co-authored-by: Erik Moura <erikian@electronjs.org>
erikian
approved these changes
Sep 8, 2025
Co-authored-by: Erik Moura <erikian@electronjs.org>
Co-authored-by: Erik Moura <erikian@electronjs.org>
erickzhao
commented
Sep 8, 2025
|
|
||
| export function createSignOpts( | ||
| properties: ComboOptions['osxSign'], | ||
| properties: Exclude<ComboOptions['osxSign'], undefined>, |
Member
Author
There was a problem hiding this comment.
After @erikian's latest round of reviews, a few things have changed in the implementation purely due to tightening up the types:
createSignOptsfor macOS and Windows no longer takes inundefined.- Missing
continueOnErroroption added to Windows. - We pass in
identity: undefinedinstead ofidentity: nullas a default for macOS since that's what the types expect for@electron/osx-sign. - More explicit control flow in
createSignOpts.
These are all improvements that can be separated out of this PR as well if we think this is too scope-creepy.
dsanders11
approved these changes
Sep 8, 2025
|
🎉 This PR is included in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bumps required Node.js version to >=22.12.0. ESM-only.