Skip to content

Conversation

@langleyd
Copy link
Member

@langleyd langleyd commented Sep 17, 2025

Add emoji suggestion character to the PatternKey and an insertEmoji action similar to slash commands(except it doesn't insert a space after the suggestion insertion)

The consumer of this will be web.

iOS and Android handle it as a no-op(just a couple of switch cases to ignore).

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.67%. Comparing base (1f9a578) to head (0ecf8b1).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
bindings/wysiwyg-wasm/src/lib.rs 0.00% 5 Missing ⚠️
bindings/wysiwyg-ffi/src/ffi_pattern_key.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   89.69%   89.67%   -0.03%     
==========================================
  Files         171      171              
  Lines       21407    21420      +13     
  Branches      294      296       +2     
==========================================
+ Hits        19202    19208       +6     
- Misses       2202     2209       +7     
  Partials        3        3              
Flag Coverage Δ
uitests 84.49% <0.00%> (ø)
uitests-ios 84.49% <0.00%> (ø)
unittests 88.49% <61.11%> (-0.01%) ⬇️
unittests-ios 87.54% <100.00%> (+0.11%) ⬆️
unittests-react 83.37% <100.00%> (+0.05%) ⬆️
unittests-rust 89.22% <22.22%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@langleyd langleyd marked this pull request as ready for review September 17, 2025 19:01
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! It's nice to have this because I had planned adding this feature to the non-RTE editor on Android, so now we can have parity 🎉 !

Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for Web but few unit tests will be great!

@langleyd
Copy link
Member Author

I added unit tests for the rust. The rest of the code is bindings(wasm + ffi) which we don't really test directly at the moment but will have another look.

@langleyd
Copy link
Member Author

Oh i can for platforms/web/lib/suggestion.ts

@sonarqubecloud
Copy link

@langleyd langleyd merged commit 029a8d2 into main Sep 22, 2025
9 checks passed
@langleyd langleyd deleted the langleyd/add_emoji_suggestion branch September 22, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants