-
Notifications
You must be signed in to change notification settings - Fork 6
Add emoji suggestions #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 89.69% 89.67% -0.03%
==========================================
Files 171 171
Lines 21407 21420 +13
Branches 294 296 +2
==========================================
+ Hits 19202 19208 +6
- Misses 2202 2209 +7
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! It's nice to have this because I had planned adding this feature to the non-RTE editor on Android, so now we can have parity 🎉 !
florianduros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good for Web but few unit tests will be great!
|
I added unit tests for the rust. The rest of the code is bindings(wasm + ffi) which we don't really test directly at the moment but will have another look. |
|
Oh i can for platforms/web/lib/suggestion.ts |
|



Add emoji suggestion character to the PatternKey and an insertEmoji action similar to slash commands(except it doesn't insert a space after the suggestion insertion)
The consumer of this will be web.
iOS and Android handle it as a no-op(just a couple of switch cases to ignore).