-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
refactor(components): [image-viewer] optimise translate calc method #13157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tolking
merged 17 commits into
element-plus:dev
from
zwgwf:refactor/optimise-translate-calculation-method
Aug 3, 2024
Merged
refactor(components): [image-viewer] optimise translate calc method #13157
tolking
merged 17 commits into
element-plus:dev
from
zwgwf:refactor/optimise-translate-calculation-method
Aug 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use trigonometric functions to calculate translate, which can support any angle
|
👋 @zwgwf, seems like this is your first time contribution to element-plus.
|
|
🧪 Playground Preview: https://element-plus.run/?pr=13157 |
tolking
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 82d2c54
Refactored
image-viewer.vueto use trigonometry for image translation. This makes the code more concise and efficient.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 82d2c54