Skip to content

Conversation

@zwgwf
Copy link
Contributor

@zwgwf zwgwf commented Jun 9, 2023

  • Use trigonometric functions to calculate translate, which can support any angle

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 82d2c54

Refactored image-viewer.vue to use trigonometry for image translation. This makes the code more concise and efficient.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 82d2c54

  • Simplify the calculation of image translation based on rotation angle using trigonometric functions (link)

* Use trigonometric functions to calculate translate, which can support any angle
@pull-request-triage
Copy link

👋 @zwgwf, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Hello @zwgwf, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13157
Please comment the example via this playground if needed.

@zwgwf zwgwf requested a review from tolking July 20, 2023 07:06
@tolking tolking merged commit 94a24dc into element-plus:dev Aug 3, 2024
@element-bot element-bot mentioned this pull request Aug 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants