Skip to content

fix(components): [select-v2] corrent focus to input when select clicked #17362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 30, 2024
Merged

fix(components): [select-v2] corrent focus to input when select clicked #17362

merged 7 commits into from
Jul 30, 2024

Conversation

@wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Jun 29, 2024 •
edited
Loading

close #17343

remote-search scenarios shoule be not initialized

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

pull-request-triage bot commented Jun 29, 2024

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 29, 2024 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jun 29, 2024

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@wzc520pyfm wzc520pyfm marked this pull request as draft June 29, 2024 10:48
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 29, 2024
@wzc520pyfm
Copy link
Contributor Author

wzc520pyfm commented Jun 29, 2024 •
edited
Loading

#16714 causes remote-search to trigger initState, I check code comments, initState should not be triggered in filter and remote scenarios.

Fixed demo: Demo

@github-actions
Copy link

github-actions bot commented Jun 29, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=17362
Please comment the example via this playground if needed.

@wzc520pyfm wzc520pyfm marked this pull request as ready for review June 29, 2024 16:08
@Hewsman
Copy link

Hewsman commented Jul 9, 2024

bump

@Hewsman
Copy link

Hewsman commented Jul 15, 2024

Bump - demo seems to have the issue fixed. @btea

tolking
tolking reviewed Jul 19, 2024
View reviewed changes
@wzc520pyfm wzc520pyfm requested a review from tolking July 20, 2024 17:05
@wzc520pyfm wzc520pyfm changed the title fix(components): [select-v2] fix remote init fix(components): [select-v2] corrent focus to input when select clicked Jul 21, 2024
@Hewsman
Copy link

Hewsman commented Jul 29, 2024

bump

@wzc520pyfm wzc520pyfm force-pushed the fix/select-v2-remote-init branch from 40ec2cf to 0af0563 Compare July 29, 2024 12:01
@btea btea merged commit a9b91d1 into element-plus:dev Jul 30, 2024
@element-bot element-bot mentioned this pull request Aug 9, 2024
Merged
3 tasks
@B1u3e B1u3e mentioned this pull request Sep 5, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
@B1u3e B1u3e mentioned this pull request Sep 25, 2024
Open
@tuskermanshu tuskermanshu mentioned this pull request Sep 27, 2024
Closed
This was referenced Oct 2, 2024
Open
Open
@DDDDD12138 DDDDD12138 mentioned this pull request Nov 14, 2024
Closed
This was referenced Jan 24, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@wzc520pyfm wzc520pyfm

Labels

CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Component] [select] [Bug Report] ElSelectV2 Labels Change To Value as Labels in Remote Search after User Interaction/ Click

4 participants

@wzc520pyfm @Hewsman @tolking @btea