Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ensure reused keys match reverse of before
Of course they’re matched keys, but that’s not what the test is
accomplishing; instead ensure they’re _reused_
  • Loading branch information
aduth committed May 5, 2017
commit c91849c116d18a7bf8988c2ce401fe9c2d36bc8b
12 changes: 7 additions & 5 deletions index.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, it } from 'mocha'
import { equal, ok } from 'assert'
import { equal, ok, deepEqual } from 'assert'
import { JSDOM } from 'jsdom'
import { createElement } from 'react'
import { renderToStaticMarkup } from 'react-dom/server'
Expand Down Expand Up @@ -115,14 +115,16 @@ describe('nodeToReact()', () => {
it('should reuse assigned key for same elements reference', () => {
document.body.innerHTML = '<ul><li>one</li><li>two</li></ul>'
const list = document.body.firstChild
let elements = nodeListToReact(list.childNodes, createElement)
const before = nodeListToReact(list.childNodes, createElement)

// Rearrange second list item before first
list.insertBefore(list.lastChild, list.firstChild)

elements = nodeListToReact(list.childNodes, createElement)
assertKey(elements[0].key)
assertKey(elements[1].key)
const after = nodeListToReact(list.childNodes, createElement)
deepEqual(
before.map(({key}) => key),
after.map(({key}) => key).reverse()
)
})
})
})