Java 9+ options #57
Merged
Java 9+ options #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
reviewed
Oct 6, 2018
lsp-java.el
Outdated
|
|
||
| (defun lsp-java--get-java-version () | ||
| "Retrieve the java version from shell command." | ||
| (let* ((java-version-output (shell-command-to-string "java -version")) |
There was a problem hiding this comment.
You must use lsp-java-java-path not "java"
|
Thanks, looks good! Can you squash the commits in a single commit, and I will merge it? |
|
Squashed. Thanks for being so responsive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to check for java 9+ and insert options as documented on the eclipse.jdt.ls readme. The arguments, which are pulled from the readme, are inserted into the start command if the
java -versionis greater than 9.