Skip to content

Support Detection of Ember/Glimmer apps as dependencies #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Support Detection of Ember/Glimmer apps as dependencies #524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56fd469
Support Detection of Ember/Glimmer apps as dependencies
elwayman02 Mar 11, 2019
00e577f
Remove redundant conditional
elwayman02 Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant conditional
  • Loading branch information
@elwayman02
elwayman02 committed Mar 11, 2019
commit 00e577f8669ed24e2de4e7f045b95338676ab91b
18 changes: 8 additions & 10 deletions src/get-project-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,18 @@ module.exports = function getProjectOptions({
return ['addon'];
}

if (dependencies || devDependencies) {
let allDeps = Object.assign({}, dependencies, devDependencies);
let allDeps = Object.assign({}, dependencies, devDependencies);

let isGlimmer = allDeps['@glimmer/blueprint'];
let isGlimmer = allDeps['@glimmer/blueprint'];

if (isGlimmer) {
return ['glimmer'];
}
if (isGlimmer) {
return ['glimmer'];
}

let isApp = allDeps['ember-cli'];
let isApp = allDeps['ember-cli'];

if (isApp) {
return ['app'];
}
if (isApp) {
return ['app'];
}

throw 'Ember CLI project type could not be determined';
Expand Down