Skip to content

Fixed error: modbus-esp8266/src/Modbus.cpp:318:25: error: comparison … #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Fixed error: modbus-esp8266/src/Modbus.cpp:318:25: error: comparison … #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view 
Fixed error: modbus-esp8266/src/Modbus.cpp:318:25: error: comparison is always false due to limited range of data type [-Werror=type-limits]
  • Loading branch information
@ArekKubacki
ArekKubacki committed Jun 5, 2023
commit cd0de238a08db8a29b4182f8ba05b482b5f35111
8 changes: 4 additions & 4 deletions src/Modbus.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,10 @@ void Modbus::slavePDU(uint8_t* frame) {
bufSize += recLen * 2 + 2; // 4 bytes for header + data
recs += 7;
}
if (bufSize > MODBUS_MAX_FRAME) { // Frame to return too large
exceptionResponse(fcode, EX_ILLEGAL_ADDRESS);
return;
}
// if (bufSize > MODBUS_MAX_FRAME) { // Frame to return too large
// exceptionResponse(fcode, EX_ILLEGAL_ADDRESS);
// return;
// }
uint8_t* srcFrame = _frame;
_frame = (uint8_t*)malloc(bufSize);
if (!_frame) {
Expand Down