Open
Conversation
zffocussss
commented
Aug 12, 2025
- http request header
- http request body size
Author
|
@gi0baro can you help have a check? |
gi0baro
requested changes
Aug 21, 2025
Member
gi0baro
left a comment
There was a problem hiding this comment.
@zffocussss thank you for your contribution.
Unfortunately, I can't merge this due to the following reasons:
- it's missing the RSGI protocol implementation. Any change in Granian regarding shared interfaces should be performed on all protocols
- I find the WSGI implementation to be very hacky (eg: manually patching the scope to store data), and I'm confused on why you
delstuff from objects - The ASGI implementation is incomplete
- The response size wouldn't be accurate
- The overall implementation might have severe performance implications (parsing all headers just to print one or few, usage of
re.match,SafeAtomswrapper, double iteration of the response, etc)
So in general, I think this should be designed quite differently.
Author
I will consider your comments.I am not a user of rsgi at all.My goal is to make granian work more flexibly than gunicorn + uvicorn any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.