Remove babel-plugin from emotion/css#2287
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b772cc:
|
|
You are right that this is sort-of unnecessary but also - it shouldn't create many problems in practice and having this as regular dep is simpler for those users that intend to use the macro variant. |
|
I'm thinking of contexts |
|
Well, how many kilobytes does this save you though? I strongly believe that there are a lot of better opportunities to handle first before this one becomes a great offender. |
|
@mitchellhamilton u were in favor of not doing this - space savings seem to be pretty big though, should we adjust this? |
|
This would be a breaking change and we're not really planning a major anytime soon so it's kind of a non-starter right now though I think I'd be mostly okay with moving it to an optional peer dep now that we can express that. |
|
Leaving this open as a reminder for ourselves so we don't forget about it when releasing v12. It won't happen any time soon though. |

What:
This PR removes babel-plugin from emotion-css dependencies
Why:
babel-plugin brings unnecessary dependencies
How:
Checklist: