Skip to content

Remove babel-plugin from emotion/css#2287

Open
bloodyowl wants to merge 2 commits intoemotion-js:mainfrom
bloodyowl:master
Open

Remove babel-plugin from emotion/css#2287
bloodyowl wants to merge 2 commits intoemotion-js:mainfrom
bloodyowl:master

Conversation

@bloodyowl
Copy link

What:

This PR removes babel-plugin from emotion-css dependencies

Why:

babel-plugin brings unnecessary dependencies

How:

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete N/A
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2021

⚠️ No Changeset found

Latest commit: 0b772cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b772cc:

Sandbox Source
Emotion Configuration

@Andarist
Copy link
Member

You are right that this is sort-of unnecessary but also - it shouldn't create many problems in practice and having this as regular dep is simpler for those users that intend to use the macro variant.

@bloodyowl
Copy link
Author

I'm thinking of contexts
where you want to keep your node_modules light (e.g. docker images). Given there's no direct link to the dependency, that could save some bandwidth and storage 😊

@Andarist
Copy link
Member

Well, how many kilobytes does this save you though? I strongly believe that there are a lot of better opportunities to handle first before this one becomes a great offender.

@bloodyowl
Copy link
Author

Screen Shot 2021-03-15 at 12 25 38

Saves ~60% of the package size (3,9MB), and 75% in disk space on APFS (9,8MB)

@Andarist
Copy link
Member

@mitchellhamilton u were in favor of not doing this - space savings seem to be pretty big though, should we adjust this?

@emmatown
Copy link
Member

This would be a breaking change and we're not really planning a major anytime soon so it's kind of a non-starter right now though I think I'd be mostly okay with moving it to an optional peer dep now that we can express that.

@Andarist
Copy link
Member

Leaving this open as a reminder for ourselves so we don't forget about it when releasing v12. It won't happen any time soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants