Conversation
🦋 Changeset detectedLatest commit: c924d4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c924d4f:
|
packages/cache/types/index.d.ts
Outdated
| element: StylisElement, | ||
| index: number, | ||
| children: Array<StylisElement>, | ||
| children: ReadonlyArray<StylisElement>, |
There was a problem hiding this comment.
Changing these to Readonly seem wrong? Aren't these arrays mutable?
packages/styled/types/base.d.ts
Outdated
| * @typeparam AdditionalProps Additional props to add to your styled component | ||
| */ | ||
| <AdditionalProps extends {}>( | ||
| <AdditionalProps extends {} = {}>( |
There was a problem hiding this comment.
It's leftover that I've missed when doing this revert: 7135e61
The other overload has this and this one seemed to have at the time when #2057 was created. It was removed as part of this PR: 0f3a2d3#diff-3fae48ecece75c5d911928f5c96c7292ac893baae5232e9868e68446de341401R93
I'll remove it - nice catch 👍
Andarist
force-pushed
the
readonly-arrays
branch
from
029fb3c to
7f1ddb4
Compare
2 participants
It's a continuation of #2057