Skip to content

[serialize]: Convert to Typescript #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andarist merged 13 commits into from
Apr 19, 2022
Merged

[serialize]: Convert to Typescript #2543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8268e1a
[serialize]: Convert to Typescript
Nov 8, 2021
6197b7b
fix: Some tests
Nov 8, 2021
38a2606
chore: Revert unrelated change
Nov 8, 2021
95e16b4
chore: Revert code behaviour changes
Nov 14, 2021
b371ac7
chore: Revert toString method addition
Nov 14, 2021
0ebd60f
chore: Changeset
Nov 14, 2021
a613327
fix: Add missing return of ComponentSelector
Nov 16, 2021
d89396e
fix: Export missing interfaces
Nov 16, 2021
7ceab45
small tweaks
Andarist Nov 19, 2021
0cc37c9
Merge branch 'ts-migration' into ts-migration-serialize
Andarist Apr 17, 2022
25d913f
fix stuff
Andarist Apr 18, 2022
0cfb120
Merge branch 'ts-migration' into ts-migration-serialize
Andarist Apr 18, 2022
62719e2
Merge branch 'ts-migration' into ts-migration-serialize
Andarist Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-elephants-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@emotion/serialize': minor
---

Source code has been migrated to TypeScript. From now on type declarations will be emitted based on that, instead of being hand-written.
2 changes: 1 addition & 1 deletion packages/css/types/tests-create-instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const emotion0 = createEmotion({ key: 'bar' })
// $ExpectType Emotion
const emotion1 = createEmotion({
key: 'foo',
container: document.head!,
container: document.head,
nonce: 'fasefw'
})

Expand Down
5 changes: 2 additions & 3 deletions packages/serialize/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "serialization utils for emotion",
"main": "dist/emotion-serialize.cjs.js",
"module": "dist/emotion-serialize.esm.js",
"types": "types/index.d.ts",
"types": "dist/emotion-serialize.cjs.d.ts",
"license": "MIT",
"repository": "https://github.com/emotion-js/emotion/tree/main/packages/serialize",
"publishConfig": {
Expand All @@ -26,8 +26,7 @@
},
"files": [
"src",
"dist",
"types/*.d.ts"
"dist"
],
"browser": {
"./dist/emotion-serialize.cjs.js": "./dist/emotion-serialize.browser.cjs.js",
Expand Down
Loading