Skip to content

Conversation

@Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2022

⚠️ No Changeset found

Latest commit: 0c0831e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c0831e:

Sandbox Source
Emotion Configuration

@srmagura
Copy link
Contributor

Yes, this does fix the .d.ts files being generated in the wrong place!

Please merge #2736 into preconstruct-upgrade first, then this PR is good to go. 🙂

BTW, when we try to merge the Preconstruct upgrade into ts-migration, we are going to get weird TS errors from packages/eslint-plugin. I can tackle those once this is merged. I forgot the copy the TypeScript error message, but it's the one that occurs when the .d.ts file would include an "unnamed type" from an external module...

srmagura and others added 2 commits April 24, 2022 18:10
@Andarist Andarist merged commit bf0a262 into main Apr 28, 2022
@Andarist Andarist deleted the preconstruct-upgrade branch April 28, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants