Skip to content

Make runtime label extraction opt-in #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andarist merged 9 commits into from
Jun 13, 2024
Merged

Make runtime label extraction opt-in #2815

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a591452
Make runtime labeling opt-in
srmagura Jul 9, 2022
c397de1
Add test for EMOTION_RUNTIME_AUTO_LABEL
srmagura Jul 9, 2022
29ae63f
Document EMOTION_RUNTIME_AUTO_LABEL
srmagura Jul 9, 2022
62a5e6b
Fix tests (maybe)
srmagura Jul 9, 2022
a3eb7ec
Fix test again
srmagura Jul 9, 2022
5591561
Fix eslint issue
srmagura Jul 9, 2022
9c8c5f0
Merge remote-tracking branch 'origin/main' into opt-in-labels
Andarist Jun 13, 2024
7b5bab3
hoist the `runtimeAutoLabel` check
Andarist Jun 13, 2024
c3c43fa
move it back to allow for mocking
Andarist Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test again
  • Loading branch information
@srmagura
srmagura committed Jul 9, 2022
commit a3eb7ecea5f81f283ce102bb604296c80b61b5da
20 changes: 3 additions & 17 deletions packages/react/__tests__/rehydration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ beforeEach(() => {
test("cache created in render doesn't cause a hydration mismatch", () => {
safeQuerySelector('body').innerHTML = [
'<div id="root">',
'<style data-emotion="stl 1pdkrhd">.stl-1pdkrhd-App {color: hotpink;}</style>',
'<div class="stl-1pdkrhd">Hello world!</div>',
'<style data-emotion="stl 168r6j">.stl-1pdkrhd {color: hotpink;}</style>',
'<div class="stl-168r6j">Hello world!</div>',
'</div>'
].join('')

Expand Down Expand Up @@ -87,21 +87,7 @@ test("cache created in render doesn't cause a hydration mismatch", () => {
container: safeQuerySelector('#root')
})

expect((console.error: any).mock.calls).toMatchInlineSnapshot(`
[
[
"Warning: Prop \`%s\` did not match. Server: %s Client: %s%s",
"className",
""stl-1pdkrhd"",
""stl-168r6j"",
"
in div (created by EmotionCssPropInternal)
in EmotionCssPropInternal (created by App)
in Wrapper (created by App)
in App",
],
]
`)
expect((console.error: any).mock.calls).toMatchInlineSnapshot(`[]`)
expect((console.warn: any).mock.calls).toMatchInlineSnapshot(`[]`)
})

Expand Down