Skip to content

ts-migration: Fix dtslint issues #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andarist merged 4 commits into from
Jul 26, 2022
Merged

ts-migration: Fix dtslint issues #2817

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e43a3f
Fix dtslint issues
srmagura Jul 10, 2022
eb48280
Update @emotion/server tsconfig comment about DOM types
srmagura Jul 14, 2022
8d06515
Remove redundant declarations
Andarist Jul 26, 2022
bd40f45
Fixed dtslint in `@emotion/cache`
Andarist Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/serialize/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ export type Interpolation<Props = unknown> =
| ArrayInterpolation<Props>
| FunctionInterpolation<Props>

declare const process: {
env: {
NODE_ENV: string
}
}

const ILLEGAL_ESCAPE_SEQUENCE_ERROR = `You have illegal escape sequence in your template literal, most likely inside content's property value.
Because you write your CSS inside a JavaScript string you actually have to do double escaping, so for example "content: '\\00d7';" should become "content: '\\\\00d7';".
You can read more about this here:
Expand Down
4 changes: 3 additions & 1 deletion packages/server/types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
"baseUrl": "../",
"forceConsistentCasingInFileNames": true,
"jsx": "react",
"lib": ["es6"],

// dom is needed because @emotion/server references packages that use DOM types
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"strict": true,
Expand Down
6 changes: 6 additions & 0 deletions packages/sheet/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ styleSheet.flush()

*/

declare const process: {
env: {
NODE_ENV: string
}
}

function sheetForTag(tag: HTMLStyleElement): CSSStyleSheet {
if (tag.sheet) {
return tag.sheet
Expand Down