Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3cf21a0
Wrote format_exception function and hard coded inclusion into system_…
hoodmane Feb 18, 2022
2ea06c8
Add Javascript wrapper, miscellaneous cleanup
hoodmane Feb 19, 2022
693f677
Fix formatting
hoodmane Feb 19, 2022
95ef456
No need for exportedAsmFunction
hoodmane Feb 20, 2022
103dca8
Use withStackSave
hoodmane Feb 20, 2022
cc31016
Free the right thing
hoodmane Feb 20, 2022
5ca4f18
Use stackAlloc({{{ POINTER_SIZE }}});
hoodmane Feb 20, 2022
aa15cc8
Remove accidental change
hoodmane Feb 20, 2022
493e22f
Add final newline to format_exception.cpp
hoodmane Feb 20, 2022
c7d1267
Add emscripten_ prefix to format_exception
hoodmane Feb 20, 2022
0231037
Add format_exception.cpp to libcxxabi
hoodmane Feb 20, 2022
af456b1
Use withStackSave correctly
hoodmane Feb 20, 2022
e233943
Remove libformatexception library
hoodmane Feb 20, 2022
83a1a4a
Various fixes
hoodmane Feb 20, 2022
5e765ab
Add test
hoodmane Feb 20, 2022
1235600
Remove addresses from test comparison
hoodmane Feb 20, 2022
a83007e
Try to fix test
hoodmane Feb 21, 2022
5f19ef5
Fix wasm-exceptions test
hoodmane Feb 21, 2022
86b703b
Fix test
hoodmane Feb 21, 2022
a773e9b
Fix INCLUDE_FULL_LIBRARY test
hoodmane Feb 21, 2022
16f160d
Fix flake8
hoodmane Feb 21, 2022
fbcf6da
Formatting fixes from sbc100
hoodmane Feb 22, 2022
8ad7932
Fix test
hoodmane Feb 22, 2022
68c129e
Return char* instead of returning by value to avoid stackAlloc
hoodmane Feb 22, 2022
c11d036
Remove FORMAT_EXCEPTION_SUPPORT setting
hoodmane Feb 22, 2022
9c0b0a6
Address more review comments
hoodmane Feb 22, 2022
439c09f
Address more review comments
hoodmane Feb 22, 2022
77376ea
Remove unneeded setting
hoodmane Feb 22, 2022
8dad972
Add formatException to EXPORTED_FUNCTIONS rather than EXPORTED_RUNTIM…
hoodmane Feb 22, 2022
dcc15f5
Edits from code review
hoodmane Feb 23, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
hoodmane committed Feb 21, 2022
commit 86b703b67b92e1db2fde3d4f256aff864fc6d81c
2 changes: 2 additions & 0 deletions src/library_exceptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ var LibraryExceptions = {
{{{ makeThrow('ptr') }}}
},

#if !DISABLE_EXCEPTION_CATCHING
$formatException__deps: ["emscripten_format_exception", "$withStackSave", "free"],
$formatException: function(excPtr){
return withStackSave(function(){
Expand All @@ -440,6 +441,7 @@ var LibraryExceptions = {
return result;
});
},
#endif
};

// In LLVM, exceptions generate a set of functions of form __cxa_find_matching_catch_1(), __cxa_find_matching_catch_2(), etc.
Expand Down