Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 11, 2022

Split out from #16922

@sbc100 sbc100 requested review from dschuff and kripken May 11, 2022 00:32
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs under site/ should also be updated for the new EM_ASM variant.

@sbc100 sbc100 force-pushed the wasm64_em_asm branch 3 times, most recently from 70dd9fc to 4932fce Compare May 11, 2022 21:20
@sbc100 sbc100 force-pushed the wasm64_em_asm branch 3 times, most recently from 26d0d0b to 78d4e66 Compare May 11, 2022 22:55
@sbc100 sbc100 requested a review from kripken May 11, 2022 23:08
@sbc100 sbc100 force-pushed the wasm64_em_asm branch 3 times, most recently from b75ffd3 to 4e18824 Compare May 12, 2022 19:51
@sbc100
Copy link
Collaborator Author

sbc100 commented May 12, 2022

Should be good now.

Note that long long/'j' is tested separately in its own test case and doesn't currently work outside of wasm64.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbc100 sbc100 enabled auto-merge (squash) May 12, 2022 19:58
@sbc100 sbc100 merged commit 9cd026c into main May 13, 2022
@sbc100 sbc100 deleted the wasm64_em_asm branch May 13, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants