Deprecate export of module handlers via EXPORTED_RUNTIME_METHODS
#17955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`print` / `printErr` are handlers that can be overridden by the user on the incoming module (just like `onAbort`) and not runtime elements that can be exported. Deprecate the export of `print` / `printErr` via `EXPORTED_RUNTIME_METHODS` in favor of `out` / `err`.
sbc100
approved these changes
Sep 30, 2022
src/modules.js
Outdated
|
|
||
| const legacyRuntimeElements = new Map(); | ||
| legacyRuntimeElements.set('print', 'out'); | ||
| legacyRuntimeElements.set('printErr', 'err'); |
Collaborator
There was a problem hiding this comment.
Does JS not have a literal syntax for this?
Collaborator
Author
There was a problem hiding this comment.
TIL, https://stackoverflow.com/a/35962243. See commit f6c2f80.
kripken
approved these changes
Sep 30, 2022
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please add a note to the changelog.
Collaborator
Author
|
Sorry for the delay, I just added a note to the changelog. |
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print/printErrare handlers that can be overridden by the user on the incoming module (just likeonAbort) and not runtime elements that can be exported. Deprecate the export ofprint/printErrviaEXPORTED_RUNTIME_METHODSin favor ofout/err.