-
Notifications
You must be signed in to change notification settings - Fork 766
Upgrade CI to Ubuntu 20.04 LTS (Focal) #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4dcede9
Try to upgrade to Ubuntu22.04
DreamOfIce fb5f34d
Fix errors
DreamOfIce b9bd245
Remove Python2 in flake8 job
DreamOfIce d9f78ac
Update Linux job
DreamOfIce 31f01c2
Merge branch 'emscripten-core:main' into main
DreamOfIce 87704c7
Update config.yml
DreamOfIce 61b1a75
Recover python2 checks
DreamOfIce eb70195
Switch to the new docker installation
DreamOfIce 7fee8fa
Fix error in Docker installation
DreamOfIce 6aad759
Fix error
DreamOfIce dacdaec
Try to change Ubuntu to 20.04LTS(focal)
DreamOfIce a264483
Fix error in pip2 installation
DreamOfIce be8a151
Change the min supported version to Ubuntu20.04
DreamOfIce 920e6d3
Revert "Update Linux job"
DreamOfIce 29f8cbe
Update test/test.py
DreamOfIce 16e32bb
Revert "Switch to the new docker installation"
DreamOfIce 2d1f231
Revert "Revert "Switch to the new docker installation""
DreamOfIce 5787161
Merge branch 'main' into main
DreamOfIce bd19b8a
fix: fix a typo
DreamOfIce ad7d28a
Update README.md
sbc100 b045d23
Update README.md
sbc100 5446822
Update .circleci/config.yml
sbc100 bc99127
Update .circleci/config.yml
sbc100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,9 @@ orbs: | |
| win: circleci/[email protected] | ||
|
|
||
| executors: | ||
| bionic: | ||
| ubuntu: | ||
| docker: | ||
| - image: buildpack-deps:bionic | ||
| - image: buildpack-deps:focal | ||
| mac: | ||
| environment: | ||
| EMSDK_NOTTY: "1" | ||
|
|
@@ -50,22 +50,26 @@ commands: | |
|
|
||
| jobs: | ||
| flake8: | ||
| executor: bionic | ||
| executor: ubuntu | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: install pip | ||
| name: install pip3 | ||
| command: | | ||
| apt-get update -q | ||
| apt-get install -q -y python-pip python3-pip | ||
| - run: python2 -m pip install --upgrade pip | ||
| apt-get install -q -y python3-pip | ||
| - run: python3 -m pip install --upgrade pip | ||
| - run: python2 -m pip install flake8==3.9.2 | ||
| - run: python3 -m pip install flake8==3.9.2 | ||
| - run: python3 -m flake8 --show-source --statistics --extend-exclude=./scripts | ||
| - run: | ||
| name: install pip2 | ||
| command: apt-get install -q -y python-pip | ||
| - run: python2 -m pip install --upgrade pip | ||
| - run: python2 -m pip install flake8==3.9.2 | ||
| - run: python2 -m flake8 --show-source --statistics --extend-exclude=./scripts | ||
sbc100 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - run: python3 -m flake8 --show-source --statistics | ||
|
|
||
| test-linux: | ||
| executor: bionic | ||
| executor: ubuntu | ||
| environment: | ||
| EMSDK_NOTTY: "1" | ||
| # This is needed because the old gcc-7 that is installed on debian/bionic | ||
|
|
@@ -174,12 +178,19 @@ jobs: | |
| test/test_path_preservation.ps1 | ||
|
|
||
| build-docker-image-x64: | ||
| executor: bionic | ||
| executor: ubuntu | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: install docker | ||
| command: apt-get update -q && apt-get install -q -y docker.io | ||
| command: | | ||
| apt-get update -q | ||
| apt-get install -q -y ca-certificates curl gnupg lsb-release | ||
| mkdir -p /etc/apt/keyrings | ||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /etc/apt/keyrings/docker.gpg | ||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| apt-get update -q | ||
| apt-get install -q -y docker-ce docker-ce-cli containerd.io docker-compose-plugin | ||
DreamOfIce marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - setup_remote_docker | ||
| # Build the `latest` version of EMSDK as docker image | ||
| - run: | ||
|
|
@@ -190,12 +201,19 @@ jobs: | |
| command: make -C ./docker version=latest test | ||
|
|
||
| publish-docker-image-x64: | ||
| executor: bionic | ||
| executor: ubuntu | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: install docker | ||
| command: apt-get update -q && apt-get install -q -y docker.io | ||
| command: | | ||
| apt-get update -q | ||
| apt-get install -q -y ca-certificates curl gnupg lsb-release | ||
| mkdir -p /etc/apt/keyrings | ||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /etc/apt/keyrings/docker.gpg | ||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| apt-get update -q | ||
| apt-get install -q -y docker-ce docker-ce-cli containerd.io docker-compose-plugin | ||
| - setup_remote_docker | ||
| - run: | ||
| name: build | ||
|
|
@@ -226,7 +244,7 @@ jobs: | |
| make -C ./docker version=${CIRCLE_TAG} alias=${CIRCLE_TAG}-arm64 only_alias=true push | ||
|
|
||
| test-bazel-linux: | ||
| executor: bionic | ||
| executor: ubuntu | ||
| steps: | ||
| - checkout | ||
| - run: apt-get install -q -y curl gnupg | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.