Skip to content

Ability to customize router URLs for custom actions, using url_path. #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 9 commits into from
Dec 19, 2014
Merged

Ability to customize router URLs for custom actions, using url_path. #2010

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d972df7
Ability to override default method names by customizing it
tanwanirahul Nov 3, 2014
ea8c405
Tests for validating custom_method_name router attribute
tanwanirahul Nov 3, 2014
6a095e9
Merge remote-tracking branch 'rahul/master'
tanwanirahul Nov 3, 2014
92ebeaa
Change decorator attribute name to url_path per suggestions
tanwanirahul Dec 19, 2014
2448cc8
Updated tests to use url_path attribute in list and detail decorators
tanwanirahul Dec 19, 2014
a8a3fed
Add url_path documention for detail_route decorator
tanwanirahul Dec 19, 2014
6aa0e30
Added documentation about url_path parameter for custom actions.
tanwanirahul Dec 19, 2014
b4a3e7f
Updates url_path info per suggestion
tanwanirahul Dec 19, 2014
8f0fef4
Updated documentation on url_path per suggestions.
tanwanirahul Dec 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change decorator attribute name to url_path per suggestions
  • Loading branch information
@tanwanirahul
tanwanirahul committed Dec 19, 2014
commit 92ebeaa040f75dbc6142355fa25d89b4c990685b
12 changes: 6 additions & 6 deletions rest_framework/routers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,26 +177,26 @@ def get_routes(self, viewset):
# Dynamic detail routes (@detail_route decorator)
for httpmethods, methodname in detail_routes:
method_kwargs = getattr(viewset, methodname).kwargs
custom_method_name = method_kwargs.pop("custom_method_name", None) or methodname
url_path = method_kwargs.pop("url_path", None) or methodname
initkwargs = route.initkwargs.copy()
initkwargs.update(method_kwargs)
ret.append(Route(
url=replace_methodname(route.url, custom_method_name),
url=replace_methodname(route.url, url_path),
mapping=dict((httpmethod, methodname) for httpmethod in httpmethods),
name=replace_methodname(route.name, custom_method_name),
name=replace_methodname(route.name, url_path),
initkwargs=initkwargs,
))
elif isinstance(route, DynamicListRoute):
# Dynamic list routes (@list_route decorator)
for httpmethods, methodname in list_routes:
method_kwargs = getattr(viewset, methodname).kwargs
custom_method_name = method_kwargs.pop("custom_method_name", None) or methodname
url_path = method_kwargs.pop("url_path", None) or methodname
initkwargs = route.initkwargs.copy()
initkwargs.update(method_kwargs)
ret.append(Route(
url=replace_methodname(route.url, custom_method_name),
url=replace_methodname(route.url, url_path),
mapping=dict((httpmethod, methodname) for httpmethod in httpmethods),
name=replace_methodname(route.name, custom_method_name),
name=replace_methodname(route.name, url_path),
initkwargs=initkwargs,
))
else:
Expand Down