Skip to content

Conversation

@jpadilla
Copy link
Contributor

@jpadilla jpadilla commented Dec 1, 2014

Removes requirements-test.txt in favor of consolidating a minimum Django version and test requirements under requirements.txt.

Closes #2170.

@lovelydinosaur
Copy link
Contributor

Yeah that seems neat & tidy to me.
We could do the whole '1.4.11+, 1.5.5+, 1.6, 1.7' Dance, but that seems a bit much for me - seems okay that some minor specifics are left implicit, and handled by the docs. This is afterall for development, not for installation purposed.

@xordoquy
Copy link
Contributor

xordoquy commented Dec 1, 2014

I'm probably missing a point, but wan't we simply put tox forward now that it's inline with travis ?

@jpadilla
Copy link
Contributor Author

jpadilla commented Dec 1, 2014

@xordoquy valid point as maybe we should be encouraging contributors to test using Tox. But I'm guessing not everyone has multiple python versions installed and using tox might be a bit "too much" than just using ./runtests.py locally and depending on Travis after they push.

@xordoquy
Copy link
Contributor

xordoquy commented Dec 1, 2014

You can still run an option that limits the builds to the existing Python. Also, they can choose their Python and Django versions they want to test against.

@lovelydinosaur
Copy link
Contributor

Personally I only run tox occasionally, but use a plain runtests.py for most things. I think it does make sense for us to continue to include a plain requirements file.

lovelydinosaur added a commit that referenced this pull request Dec 2, 2014
Consolidate Django and test requirements
@lovelydinosaur lovelydinosaur merged commit deec61e into encode:master Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

django version requirements

3 participants