Skip to content

Respect to_field property of ForeignKey relations #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harper04 wants to merge 15 commits into from
Closed

Respect to_field property of ForeignKey relations #2435

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
067360c
Added support for the to_field on ForeignKey Fields.
Harper04 Jan 19, 2015
8263048
* many to many relationship do not have to_fields
Harper04 Jan 19, 2015
d47f29a
Fixed the rest of the test cases.
Harper04 Jan 19, 2015
49ecaa7
Add support for Django <1.6 where appearently no to_field existed
Harper04 Jan 19, 2015
6369f93
* Removed 2 unnecessary lines
Harper04 Jan 19, 2015
6007463
Merge branch 'master' of https://github.com/tomchristie/django-rest-f…
Harper04 Jan 19, 2015
f808b6c
* Removed SlugRelatedField optimization
Harper04 Jan 20, 2015
77eeefa
Merge branch 'master' of https://github.com/tomchristie/django-rest-f…
Harper04 Jan 20, 2015
3dd5ddd
Merge branch 'master' of https://github.com/tomchristie/django-rest-f…
Harper04 Jan 20, 2015
6ccc45e
Ups. Removed the wrong line. (optimizer)
Harper04 Jan 20, 2015
64c49f8
From this i believe it is field_name pre django 1.6. I still don’t ha…
Harper04 Jan 20, 2015
a496c52
to_field is rel.field_name at <1.6. love pdb and pip!
Harper04 Jan 20, 2015
8096997
Merge branch 'master' of https://github.com/tomchristie/django-rest-f…
Harper04 Apr 16, 2015
54e16f4
Merge branch 'master' into model-tofield-serializer
Harper04 Apr 16, 2015
5ca9841
* updated patch to latest DRF revision
Harper04 Apr 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* many to many relationship do not have to_fields
  • Loading branch information
@Harper04
Harper04 committed Jan 19, 2015
commit 8263048af44bc1f3cf10ce740ee87e67b8a2a99a
7 changes: 5 additions & 2 deletions rest_framework/utils/model_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ def _get_forward_relationships(opts):
model_field=field,
related=_resolve_model(field.rel.to),
to_many=True,
# to_fields is an array but django lets you only set one to_field
to_field=field.to_fields[0] if len(field.to_fields) else None,
# manytomany do not have to_fields
to_field=None,
has_through_model=(
not field.rel.through._meta.auto_created
)
Expand All @@ -134,6 +134,7 @@ def _get_reverse_relationships(opts):
model_field=None,
related=relation.model,
to_many=relation.field.rel.multiple,
to_field=relation.field.to_fields[0] if len(relation.field.to_fields) else None,
has_through_model=False
)

Expand All @@ -144,6 +145,8 @@ def _get_reverse_relationships(opts):
model_field=None,
related=relation.model,
to_many=True,
# manytomany do not have to_fields
to_field=None,
has_through_model=(
(getattr(relation.field.rel, 'through', None) is not None)
and not relation.field.rel.through._meta.auto_created
Expand Down