-
-
Notifications
You must be signed in to change notification settings - Fork 7k
FIX: Don't default to list in method args #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
FIX: Don't default to list in method args
Fixes @list_route and @detail_route so that they don't initialize their `methods` parameter as a list. In some cases the list gets cleared, and the result is that default parameter is now empty, and may get reused unexpectedly.
- Loading branch information
commit 7bb5fd270da98d8957efb4bf0e4bd4679ddbcf5f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,10 +109,12 @@ def decorator(func): | |
| return decorator | ||
|
|
||
|
|
||
| def detail_route(methods=['get'], **kwargs): | ||
| def detail_route(methods=None, **kwargs): | ||
| """ | ||
| Used to mark a method on a ViewSet that should be routed for detail requests. | ||
| """ | ||
| if methods is None: | ||
| methods = ['get'] | ||
| def decorator(func): | ||
| func.bind_to_methods = methods | ||
| func.detail = True | ||
|
|
@@ -121,10 +123,12 @@ def decorator(func): | |
| return decorator | ||
|
|
||
|
|
||
| def list_route(methods=['get'], **kwargs): | ||
| def list_route(methods=None, **kwargs): | ||
| """ | ||
| Used to mark a method on a ViewSet that should be routed for list requests. | ||
| """ | ||
| if methods is None: | ||
| methods = ['get'] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a newline here, also let's use the |
||
| def decorator(func): | ||
| func.bind_to_methods = methods | ||
| func.detail = False | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline here, also let's use the
methods = ['get'] if (methods is None) else methodsstyle.