Skip to content

fix DISTINCT for Oracle databases #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trollknurr wants to merge 6 commits into from
Closed

fix DISTINCT for Oracle databases #2935

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7813d2f
fix DISTINCT for Oracle databases
trollknurr May 14, 2015
c47ec60
no need to do distinct on every loop cycle & add analogue of distinct…
trollknurr May 14, 2015
de95598
removed using `view.model.objects`
trollknurr May 15, 2015
0906bf2
fix empty and_query
trollknurr May 15, 2015
745d8d0
added comment
Jun 3, 2015
e8b23c4
thin logic
Jun 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix empty and_query
  • Loading branch information
@trollknurr
trollknurr committed May 15, 2015
commit 0906bf2c08e67eb43789ef976a784a4da01a08bc
12 changes: 7 additions & 5 deletions rest_framework/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,13 @@ def filter_queryset(self, request, queryset, view):
for orm_lookup in orm_lookups]
and_queries.append(reduce(operator.or_, or_queries))

if settings.DATABASES[queryset.db]["ENGINE"] == "django.db.backends.oracle":
pk_list = queryset.filter(reduce(operator.and_, and_queries)).values_list('pk', flat=True)
return queryset.filter(pk__in=frozenset(pk_list))
else:
return queryset.filter(reduce(operator.and_, and_queries)).distinct()
if and_queries:
if settings.DATABASES[queryset.db]["ENGINE"] == "django.db.backends.oracle":
Copy link
Contributor

@lovelydinosaur lovelydinosaur May 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want a brief comment here regarding needing this behavior for oracle and distinct.

Copy link
Contributor Author

@trollknurr trollknurr Jun 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchristie According to Oracle DB limits there is no capability to make a DISTINT on *LOB. There is a need to use SearchFilter with TextField (for example). That's why i pull this workaround for Oracle.

Copy link
Contributor

@lovelydinosaur lovelydinosaur Jun 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification: I was meaning that we should have a code comment for this.

pk_list = queryset.filter(reduce(operator.and_, and_queries)).values_list('pk', flat=True)
return queryset.filter(pk__in=frozenset(pk_list))
else:
return queryset.filter(reduce(operator.and_, and_queries)).distinct()
return queryset


class OrderingFilter(BaseFilterBackend):
Expand Down