Skip to content

MultipleChoiceField empties incorrectly on a partial update using multipart/form-data (#2894) #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xordoquy merged 3 commits into from
Jun 1, 2015
Merged

MultipleChoiceField empties incorrectly on a partial update using multipart/form-data (#2894) #2993

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
989c081
Failing test case for #2894
xordoquy Jun 1, 2015
94e2d3c
Test case upgrade to use partial data
xordoquy Jun 1, 2015
5c90bf9
Fix for #2894 thanks to @carljm
xordoquy Jun 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test case upgrade to use partial data
  • Loading branch information
@xordoquy
xordoquy committed Jun 1, 2015
commit 94e2d3ca610ec1fdb97641a094801f69a1ab2613
5 changes: 4 additions & 1 deletion tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,10 +1018,13 @@ class TestMultipleChoiceField(FieldValues):
]
)

def test_against_partial_updates(self):
def test_against_partial_and_full_updates(self):
# serializer = self.Serializer(data=MockHTMLDict())
from django.http import QueryDict
field = serializers.MultipleChoiceField(choices=(('a', 'a'), ('b', 'b')))
field.partial = False
assert field.get_value(QueryDict({})) == []
field.partial = True
assert field.get_value(QueryDict({})) == rest_framework.fields.empty


Expand Down