Skip to content

IPAddressField improvements #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 9 commits into from
Jun 4, 2015
Merged

IPAddressField improvements #3008

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d5eee0
add IPAddressField, update docs
Ins1ne Feb 28, 2015
313b3d7
Update ModelSerializer mappings
Ins1ne Feb 28, 2015
de72022
Merge branch 'master' of https://github.com/Ins1ne/django-rest-framew…
Ins1ne Feb 28, 2015
c44376c
remove unnecessary check
Ins1ne Mar 4, 2015
1d883e0
Add two more tests for IPAddressField, checking the IPv4 and IPv6 pro…
andreagrandi Mar 22, 2015
a0049dd
Add a blank line to make lint happier
andreagrandi Mar 22, 2015
466575b
Lowercase the input
andreagrandi Mar 26, 2015
d6effbf
Remove unpack_ipv4 parameter
andreagrandi Apr 2, 2015
dee5fb5
Merge remote-tracking branch 'reference/master' into feature/ipaddres…
xordoquy Jun 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unpack_ipv4 parameter
  • Loading branch information
@andreagrandi
andreagrandi committed Apr 2, 2015
commit d6effbf779d5afe0cf52afdd771621641f3ef05f
9 changes: 5 additions & 4 deletions rest_framework/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,17 +661,18 @@ class IPAddressField(CharField):
'invalid': _('Enter a valid IPv4 or IPv6 address.'),
}

def __init__(self, protocol='both', unpack_ipv4=False, **kwargs):
def __init__(self, protocol='both', **kwargs):
self.protocol = protocol.lower()
self.unpack_ipv4 = unpack_ipv4
self.unpack_ipv4 = (self.protocol == 'both')
super(IPAddressField, self).__init__(**kwargs)
validators, error_message = ip_address_validators(protocol, unpack_ipv4)
validators, error_message = ip_address_validators(protocol, self.unpack_ipv4)
self.validators.extend(validators)

def to_internal_value(self, data):
if data and ':' in data:
try:
return clean_ipv6_address(data, self.unpack_ipv4)
if self.protocol in ('both', 'ipv6'):
return clean_ipv6_address(data, self.unpack_ipv4)
except DjangoValidationError:
self.fail('invalid', value=data)

Expand Down