Skip to content

Unsaved file objects may not have an associated URL. #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 1 commit into from
Jun 24, 2015
Merged

Unsaved file objects may not have an associated URL. #3074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unsaved file objects may not have an associated URL.
  • Loading branch information
@lovelydinosaur
lovelydinosaur committed Jun 24, 2015
commit 321133242f40e18b3d7564a43a3b515c17f3e40c
6 changes: 5 additions & 1 deletion rest_framework/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,8 +1198,12 @@ def to_internal_value(self, data):
return data

def to_representation(self, value):
if not value:
return None

if self.use_url:
if not value:
if not getattr(value, 'url', None):
# If the file has not been saved it may not have a URL.
return None
url = value.url
request = self.context.get('request', None)
Expand Down