Skip to content

Duplicated IPAddressField validation errors #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 1 commit into from
Aug 20, 2015
Merged

Duplicated IPAddressField validation errors #3249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test to repro duplicate validation error 
Using the ModelSerializer with a model containing a GenericIPAddressField
produces duplicated validation error messages.
  • Loading branch information
@callorico
callorico committed Aug 7, 2015
commit bc6bf7236b95e9fc150b4a36bd80d6f82ba7356b
16 changes: 16 additions & 0 deletions tests/test_model_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,22 @@ class Meta:
self.assertEqual(unicode_repr(TestSerializer()), expected)


class TestGenericIPAddressFieldValidation(TestCase):
def test_ip_address_validation(self):
class IPAddressFieldModel(models.Model):
address = models.GenericIPAddressField()

class TestSerializer(serializers.ModelSerializer):
class Meta:
model = IPAddressFieldModel

s = TestSerializer(data={'address': 'not an ip address'})
self.assertFalse(s.is_valid())
self.assertEquals(1, len(s.errors['address']),
'Unexpected number of validation errors: '
'{0}'.format(s.errors))


# Tests for relational field mappings.
# ------------------------------------

Expand Down