Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't display filter control on detail views
  • Loading branch information
lovelydinosaur committed Aug 27, 2015
commit 0b77e733a8ba0b4c88e3a144361946d5323f1f58
14 changes: 12 additions & 2 deletions rest_framework/renderers.py
Original file line number Diff line number Diff line change
Expand Up @@ -601,10 +601,20 @@ def get_description(self, view, status_code):
def get_breadcrumbs(self, request):
return get_breadcrumbs(request.path, request)

def get_filter_form(self, view, request):
def get_filter_form(self, data, view, request):
if not hasattr(view, 'get_queryset') or not hasattr(view, 'filter_backends'):
return

# Infer if this is a list view or not.
paginator = getattr(view, 'paginator', None)
if (paginator is not None and data is not None):
try:
paginator.get_results(data)
except (TypeError, KeyError):
return
elif not isinstance(data, list):
return

queryset = view.get_queryset()
elements = []
for backend in view.filter_backends:
Expand Down Expand Up @@ -667,7 +677,7 @@ def get_context(self, data, accepted_media_type, renderer_context):
'delete_form': self.get_rendered_html_form(data, view, 'DELETE', request),
'options_form': self.get_rendered_html_form(data, view, 'OPTIONS', request),

'filter_form': self.get_filter_form(view, request),
'filter_form': self.get_filter_form(data, view, request),

'raw_data_put_form': raw_data_put_form,
'raw_data_post_form': raw_data_post_form,
Expand Down