Skip to content

Remove browser overriding #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovelydinosaur wants to merge 8 commits into from
Closed

Remove browser overriding #3410

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60c1725
Add test to check if a 415 status is returned for unsupported media t…
Aug 3, 2015
8cae462
Merge pull request #3401 from nryoung/update-transifex-client-reqs
xordoquy Sep 15, 2015
566812a
Remove method and content overriding
lovelydinosaur Sep 17, 2015
4b4130e
Fix request cloning, so method becomes set
lovelydinosaur Sep 17, 2015
66e3722
Merge branch 'method-not-allowed-not-raised' of https://github.com/ca…
lovelydinosaur Sep 17, 2015
343fd5e
Merge branch 'canassa-method-not-allowed-not-raised' into remove-cont…
lovelydinosaur Sep 17, 2015
b8ebe29
Import sorting
lovelydinosaur Sep 17, 2015
eec1156
AJAX forms in admin interface
lovelydinosaur Sep 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions tests/test_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from django.utils import six

from rest_framework import generics, routers, serializers, status, viewsets
from rest_framework.parsers import JSONParser
from rest_framework.renderers import (
BaseRenderer, BrowsableAPIRenderer, JSONRenderer
)
Expand Down Expand Up @@ -79,6 +80,14 @@ def get(self, request, **kwargs):
return Response(DUMMYCONTENT, status=DUMMYSTATUS, content_type='setbyview')


class JSONView(APIView):
parser_classes = (JSONParser,)

def post(self, request, **kwargs):
assert request.data
return Response(DUMMYCONTENT)


class HTMLView(APIView):
renderer_classes = (BrowsableAPIRenderer, )

Expand Down Expand Up @@ -114,6 +123,7 @@ class HTMLNewModelView(generics.ListCreateAPIView):
url(r'^.*\.(?P<format>.+)$', MockView.as_view(renderer_classes=[RendererA, RendererB, RendererC])),
url(r'^$', MockView.as_view(renderer_classes=[RendererA, RendererB, RendererC])),
url(r'^html$', HTMLView.as_view()),
url(r'^json$', JSONView.as_view()),
url(r'^html1$', HTMLView1.as_view()),
url(r'^html_new_model$', HTMLNewModelView.as_view()),
url(r'^html_new_model_viewset', include(new_model_viewset_router.urls)),
Expand Down Expand Up @@ -203,6 +213,25 @@ def test_specified_renderer_is_used_on_format_query_with_matching_accept(self):
self.assertEqual(resp.status_code, DUMMYSTATUS)


class UnsupportedMediaTypeTests(TestCase):
urls = 'tests.test_response'

def test_should_allow_posting_json(self):
response = self.client.post('/json', data='{"test": 123}', content_type='application/json')

self.assertEqual(response.status_code, 200)

def test_should_not_allow_posting_xml(self):
response = self.client.post('/json', data='<test>123</test>', content_type='application/xml')

self.assertEqual(response.status_code, 415)

def test_should_not_allow_posting_a_form(self):
response = self.client.post('/json', data={'test': 123})

self.assertEqual(response.status_code, 415)


class Issue122Tests(TestCase):
"""
Tests that covers #122.
Expand Down